-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add real gcc ver chk #2118
add real gcc ver chk #2118
Conversation
Doh, sry totally forgot about this :/ This is nice to be able to tell about any binary what exact version it was built with :) To fix the detection issue in cmake however it is potentially enough to replace "arm-none-eabi-g++ -v" with "${CMAKE_CXX_COMPILER} -v" (havent tested this yet :)) Will send that as a separate PR, this I'll try to read in the evening it should go in regardless 👍 |
Hi , |
No. It’s somehow not accurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not.
It would be better if there was a single message versus one per ELF file -- because now the percentage ROM utilization scrolls off the screen. |
Thanks! I'll submit with a new PR with compare. |
After thinking, I think it's not quite make sense to compress the output, since it could be possible if and about flushing the screen, I think other things do that as well, for example cmake itself:
SO i added a new PR just simply tuned the print order. |
it's because it happend on me and gull that the current check gcc ver isn't that reliable.
This is read from elf target which were compiled, which should be accurate
NOTE that i'm not sure if this will break pipeline. i need to check on my fork HOWEVEReven after it passed from my side it's still need a nightly release to check workreadelf cmd is from binutils.
which idk if it's included in pipeline.(edit: pipeline compile passed)https://github.com/zxkmm/mayhem-firmware/actions/runs/8778357213