fix a weird line if we have set menu color #2158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this seems impact the outline of other buttons, that maybe not quite elegant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR aim to fix that the "Menu Color" feature have a not quite elegant line of button grid top
and when i was writing this, i think we can have a better global theme set, should be beautiful.
after discussion, we can decide if we agree to cost some SPI flash (we need to include pmem to Style file) to have a Style class impl to always match the theme color, which can set title bar color and status bar color and button color to match the themei gave up the second plan cuz idk how to do the style things.