transparent splash logo & fix tab widget color glitch #2256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal of this change is to fix this situation that the splash screen has a black square if you are using not default theme.
The original fake transparent color is (255,0,255), but when i make the bg became it, the bmp always took more spaces. so if i do (1,1,1), it would also be meaningless.
I'm not familiar with bmp format but i'm guessing some of the color seems tooks more spaces than black.
there are only two places that use this func: draw default splash (not custom) and modal warning image. and if someone added more in the future, you can freely choose not to apply transparent when you call that func.
and considering in the most case, black is the background color, so i think it's more appropriate.