Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent splash logo & fix tab widget color glitch #2256

Merged
merged 6 commits into from
Sep 22, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Sep 21, 2024

  1. made black as transparent color (i checked the code, all the place who use this func is not impacted, harmless, previously its purple), work i promised to do in add bitmap arr to file (or reverse) converter #2248
  2. same fix for the fake 3D effect for grid (reword of #2158 #2249)

the goal of this change is to fix this situation that the splash screen has a black square if you are using not default theme.

The original fake transparent color is (255,0,255), but when i make the bg became it, the bmp always took more spaces. so if i do (1,1,1), it would also be meaningless.

I'm not familiar with bmp format but i'm guessing some of the color seems tooks more spaces than black.

there are only two places that use this func: draw default splash (not custom) and modal warning image. and if someone added more in the future, you can freely choose not to apply transparent when you call that func.

and considering in the most case, black is the background color, so i think it's more appropriate.

@zxkmm zxkmm changed the title make the transparent color to black instead of purple transparent splash logo & fix tab widget color glitch Sep 21, 2024
@zxkmm zxkmm marked this pull request as ready for review September 21, 2024 04:08
@zxkmm zxkmm requested a review from htotoo September 21, 2024 04:09
@htotoo htotoo removed their request for review September 21, 2024 06:02
@zxkmm zxkmm requested a review from eried September 21, 2024 06:52
@zxkmm
Copy link
Contributor Author

zxkmm commented Sep 21, 2024

image

@zxkmm zxkmm enabled auto-merge (squash) September 21, 2024 11:04
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxkmm zxkmm merged commit 42233e6 into portapack-mayhem:next Sep 22, 2024
3 checks passed
htotoo pushed a commit to htotoo/portapack-mayhem that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants