Splash resize #2353
Merged
Splash resize #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htotoo
pushed a commit
to htotoo/portapack-mayhem
that referenced
this pull request
Nov 11, 2024
* resized default splash screens to maximum displayed size * fix splash screen X,Y position to 0,16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Y position of the splash screen bitmap was not right, by 1 pixel.
The X offset was badly set, and anyway is not used. I set it back to zero, so if at some point someone is fixing the display bitmap, splash screen will still be ok.
The definite displayed size of a splash is 240x304 pixels.
Tests have shown that:
=> the default splash bitmaps have been resized to maximum displayed size
=> wiki page have been updated : https://github.com/portapack-mayhem/mayhem-firmware/wiki/Create-a-custom-splash-screen