Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 응답 설명 최신화 #659

Merged
merged 1 commit into from
Nov 6, 2024
Merged

SDK 응답 설명 최신화 #659

merged 1 commit into from
Nov 6, 2024

Conversation

finalchild
Copy link
Contributor

  • 빌링키 응답 관련 필드 오류 수정
  • pgCode, pgMessage 필드 추가
  • != null 비교가 undefined를 포함하는데, 이 점을 알지 못하고 !== null로 비교하여 오류 발생하는 경우가 있음. undefined로 응답하는 것이 고정되어 있으므로 !== undefined로 비교하도록 함

@finalchild finalchild requested a review from a team as a code owner November 6, 2024 08:35
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 8:42am

Copy link

sonarcloud bot commented Nov 6, 2024

@CirnoV
Copy link
Member

CirnoV commented Nov 6, 2024

예시 코드는 더 간단하게 if (response.code) { 이렇게 하는건 어떨까요?

@finalchild
Copy link
Contributor Author

예시 코드는 더 간단하게 if (response.code) { 이렇게 하는건 어떨까요?

@CirnoV
제가 별로 좋아하는 스타일의 코드는 아니긴 합니다 ㅎㅎ...
빈 문자열이 오류 코드로 나가는 일은 없으니까 문제는 없지만 code !== undefined가 제일 명시적인 것 같습니다.

@finalchild finalchild merged commit 116a9ca into main Nov 6, 2024
4 checks passed
@finalchild finalchild deleted the fix/sdk-response branch November 6, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants