Document soft-dependencies of Ark on R packages and warn if not met #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
commented
Jun 26, 2024
DavisVaughan
approved these changes
Jun 26, 2024
|
I think I put usethis on that list purely to exercise dev usethis + Positron more, as dev usethis uses cli heavily in its UI. I am working towards a near-term usethis release. But I think that's just going to give people a nicer, prettier life. It's not actually a matter of function. |
lionel-
force-pushed
the
feature/roxygen-check
branch
from
0e5866f
to
4196c49
Compare
lionel-
force-pushed
the
feature/roxygen-check
branch
from
4196c49
to
b37964e
Compare
lionel-
force-pushed
the
feature/roxygen-check
branch
from
b37964e
to
38bf4e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for our package min-version dependencies: https://github.com/posit-dev/ark/blob/feature/roxygen-check/doc/package-dependencies.md
These requirements are usually for enhancements or for bugs that we have worked around. There is one bugfix in roxygen that is annoying, so we now warn on load:
To support the nice cli output I've added some tools ported from rlang's
standalone-cli.Rfile.The fix is not on CRAN yet but @hadley will do a release soon.
@jennybc The enhancement/bugfixes for usethis are missing from this list. Do you remember what they are about?