-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lobstr implementation of object_size #488
Conversation
Does this also address posit-dev/positron#478? |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I see you also ported the lobstr tests, which is nice.
Ideally we wouldn't have two implementations, but it seems hard to share it since a package can't depend on harp. Maybe we should split harp into CRAN-able and un-CRAN-able parts. That said there's also no guarantee that lobstr can remain on CRAN in the long term.
We could also have done it the other way around, e.g. using https://github.com/rust-lang/cc-rs to build the lobstr sources as part of our build.
But let's worry about all that if the maintenance of this Rust port turns out to be a burden.
Co-authored-by: Lionel Henry <[email protected]>
Implements
object_size
as a port of the lobstr implementation, which should be more resilient to ALTREP objects, although it also:It fixes issues that can be observed in: posit-dev/positron#4512