-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .rs.api.versionInfo()
#531
Conversation
mode = Sys.getenv("POSITRON_MODE"), | ||
version = package_version(Sys.getenv("POSITRON_VERSION")), | ||
long_version = Sys.getenv("POSITRON_LONG_VERSION"), | ||
ark_version = .ps.ark.version() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be nice to include the ark version here. Thoughts?
# info <- list() | ||
|
||
current_year <- format(Sys.Date(), "%Y") | ||
positron_citation <- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here for what RStudio has for a citation: https://github.com/rstudio/rstudio/blob/main/src/cpp/session/resources/CITATION.in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, do you think RStudio should have used https://posit.co/
?
# https://github.com/rstudio/rstudio/blob/bb729e14867f6f95e26600d8b38e4551402cf7de/src/cpp/r/R/Api.R#L135-L145 | ||
# info <- list() | ||
|
||
current_year <- format(Sys.Date(), "%Y") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
Addresses posit-dev/positron#4081
Addresses posit-dev/positron#4706
Goes together with posit-dev/positron#4703
There are a few differences between what I have in this draft and what
.rs.api.versionInfo()
returns for RStudio, especially on Workbench.CurrentlyWe will havemode
will be "web" rather than "server" for non-desktop use. I did this because it is what VS Code uses internally throughout. Is it a problem for us to have something different here? See https://github.com/posit-dev/positron/pull/4703/files#r1764143168mode
be "server", for consistency with RStudio.edition
orrelease_name
, since Positron doesn't have those. The desktop version of RStudio also doesn't haveedition
.QA Notes
In the R console, you should see these types of results: