Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split inputs by newlines #536

Merged
merged 36 commits into from
Oct 4, 2024
Merged

Split inputs by newlines #536

merged 36 commits into from
Oct 4, 2024

Conversation

DavisVaughan
Copy link
Contributor

@DavisVaughan DavisVaughan commented Sep 18, 2024 •
edited by lionel-
Loading

@lionel- lionel- force-pushed the bugfix/split-input branch 2 times, most recently from b46e79d to aa5c30a Compare September 19, 2024 15:00
lionel-
lionel- reviewed Sep 23, 2024
View reviewed changes
crates/ark/src/interface.rs Outdated Show resolved Hide resolved
crates/ark/src/interface.rs Outdated Show resolved Hide resolved
crates/ark/src/interface.rs Show resolved Hide resolved
@lionel- lionel- mentioned this pull request Sep 23, 2024
Merged
@DavisVaughan DavisVaughan mentioned this pull request Sep 24, 2024
Open
@DavisVaughan DavisVaughan marked this pull request as ready for review October 3, 2024 14:55
@DavisVaughan DavisVaughan changed the title WIP: Split inputs by newlines Split inputs by newlines Oct 3, 2024
lionel- and others added 20 commits October 4, 2024 13:25
@lionel-
Add lines() util to preserve trailing lines
fd13570
@lionel-
Draft handle_input()
0587617
@DavisVaughan @lionel-
WIP handling for pending line in read_console()
3da6106
@lionel-
Fix output of intermediate expressions
75b7cad
@lionel-
Make detection of prompt types more robust
da79ecf
@DavisVaughan @lionel-
Rework lines() to return an iterator
d709454
@DavisVaughan @lionel-
Flesh out safety bullet
7a444e6
@DavisVaughan @lionel-
Clean up buffer_overflow_call()
f290f85
@DavisVaughan @lionel-
Remove comment
bc67135
@DavisVaughan @lionel-
Update comment about incomplete input handling
4591929
@DavisVaughan @lionel-
Throw an R error if we see incomplete user inputs
85acec5 
Should only happen in Jupyter Notebooks. Positron should always check for complete inputs before sending them through.
@DavisVaughan @lionel-
Add a note about input replies and incomplete results
f85f3f8
@lionel-
Add more comments about input handling
9512c70
@lionel-
Return error from check_console_input()
df5f3f4
@lionel-
Document the ReadConsole state machine
fb4e776
@lionel-
Panic when an incomplete prompt is detected in ReadConsole
b65d6a7
@lionel-
Document current issue with large input errors
f65d942
@lionel-
Tweak tests
2449def
@DavisVaughan @lionel-
Set R_CLI_HIDE_CURSOR after all
c99d6b2
@DavisVaughan @lionel-
Return an amalthea::Result<()> from on_console_input()
bf3e54b 
Allowing us to manually throw an R error from the POD site
@lionel- lionel- merged commit 3663460 into main Oct 4, 2024
6 checks passed
@lionel- lionel- deleted the bugfix/split-input branch October 4, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lionel- lionel- lionel- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ark: Issues with incomplete inputs in Jupyter apps
2 participants
@DavisVaughan @lionel-