Console: Scrolling can get into a broken state after Console has been moved #2116
Comments
wesm
added
area: console
|
@cderv Also reported seeing a similar issue with double overlay rendering of console output on Windows in a Console that was in a maximized state of the Panel in its typical location in the center. |
|
We've had a few more reports of this since, bringing back to Triage |
|
I am one of those recent reports and I had definitely flipped through some of our preset layouts that move the Console. It may have been the first time I (temporarily) moved the Console from its default location and this maneuver definitely coincided with the first time I've seen this weird scrolling/overlay phenomenon. |
|
FWIW I am never moved the layout and moved the console. Though regarding moving stuff around, it saw this the same as I tried to install some extension, and move them from left sidebar to right panel. Nothing to do with the R console, but could be seen as "messing with layout" category maybe. 🤷♂️ After closing Positron and reopening, I can't reproduce yet. So I am not sure what caused the behavior |
|
Reported again in #4477 |
This change fixes an issue in which the Console can draw incorrectly after being moved. The problem was just two lines being out of order: - the console stores console instances by session ID - due to the error, we never clean up the reference to the old session ID - when the console is moved, all the old session IDs are replayed as new consoles - since we reused the console instance across several sessions (by design!) the consoles for every "session" are the same instance and are painted on top of each other Addresses #2116. ### QA Notes As part of fixing this, @softwarenerd and I discovered a reliable repo for it. 1. With either R or Python, shut down the session (manually). 2. Wait until shutdown has completed, then start a new R or Python session (use the Restart button in the console or the Power button) 3. Repeat steps 1 and 2 two or three times. Note that you do need to do a full shutdown/start so you get an entirely new session ID. 4. Drag the Console to a new location.
Verified FixedPositron Version(s) : 2024.09.0-38 Test scenario(s)Followed repro steps in PR.. scroll works as expected now in Console. Link(s) to TestRail test cases run or created: |
Thanks to @chendaniely for his usability testing session yesterday. We discovered that scrolling in the Console can get pretty broken after you move the Console from its original location:
scrolling.mp4
It remains broken if you move it back to its original location:
scrolling-2.mp4
I don't have an exact reproducible set of steps for this and cannot currently reproduce the problem with the R console.
The text was updated successfully, but these errors were encountered: