Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom size dialog window in the plot pane should accept new values after hitting "enter" #4203

Closed
strengejacke opened this issue Aug 1, 2024 · 6 comments
Assignees
Labels
area: plots Issues related to Plots category. enhancement New feature or request support

Comments

@strengejacke
Copy link

System details:

Positron and OS details:

Positron Version: 2024.07.0 (system setup) build 2024.07.0-125
Code - OSS Version: 1.91.0
Commit: cae4905
Date: 2024-07-31T22:26:02.970Z
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

Interpreter details:

R 4.4.1

Describe the issue:

When I change the custom size for plots in the plot pane, I need to click with the mouse on the OK button to accept. Would be nice if the "enter" key would also trigger the OK button.

@sharon-wang
Copy link
Member

sharon-wang commented Aug 1, 2024

This is closely related to #3491 and any other custom modals in Positron that have a default button (such as OK).

@strengejacke
Copy link
Author

strengejacke commented Aug 1, 2024

You mean #3491? @ posit-team, feel free to close this in favor of #3491

@sharon-wang
Copy link
Member

Oops, yes that's what I meant :)

@juliasilge shall we keep just one of #3491 or #4203 open and transfer the labels and milestone as appropriate?

@juliasilge
Copy link
Contributor

Let's keep them both open so we can validate the fixes for both cases. I will update so both are in 2024.09.0 Pre-Release.

@softwarenerd
Copy link
Contributor

softwarenerd commented Sep 18, 2024

This issue is addressed in #4739.

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.09.0-81
OS Version          : OSX

Test scenario(s)

Custom size dialog can be accepted with Enter

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: plots Issues related to Plots category. enhancement New feature or request support
Projects
None yet
Development

No branches or pull requests

5 participants