Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Painting bugs with the Data Explorer column null percentage graph #4291

Closed
softwarenerd opened this issue Aug 8, 2024 · 5 comments
Closed

Painting bugs with the Data Explorer column null percentage graph #4291

softwarenerd opened this issue Aug 8, 2024 · 5 comments
Assignees
@softwarenerd
Labels
area: data explorer Issues related to Data Explorer category. area: ui Issues related to UI category.
Milestone
2024.09.0 Pre-Rel...

Comments

@softwarenerd
Copy link
Contributor

softwarenerd commented Aug 8, 2024 •
edited
Loading

System details:

image

Positron and OS details:

Positron Dev Version: 2024.08.0 build 0
Code - OSS Version: 1.91.0
Commit: Unknown
Date: Unknown
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

Interpreter details:

Python 3.11.9

Describe the issue:

There are a couple of painting bugs with the Data Explorer column null percentage graph.

First, when 100% of the values in the column are null, the graph is painting as though some small percentage of the values are non-null:

100-percent-bug

The graph above should be 100% red with a grey border.

Second, the graph is bleeding outside of the rounded corners of the indicator:

image

The graph above should have a clean grey border.

Steps to reproduce the issue:

  1. For the first issue, open a Data Explorer and add a row filter to it that causes the column null percentage graph to be 100%.
  2. For the second issue, open a Data Explorer and add a row filter to it that causes the column null percentage graph to be a small percentage - say 2%.

Expected or desired behavior:

The column null percentage graph should be drawn without these issues.

Were there any error messages in the UI, Output panel, or Developer Tools console?

No.
@softwarenerd softwarenerd added area: data explorer Issues related to Data Explorer category. area: ui Issues related to UI category. labels Aug 8, 2024
@softwarenerd softwarenerd added this to the 2024.09.0 Pre-Release milestone Aug 8, 2024
@softwarenerd softwarenerd self-assigned this Aug 8, 2024
@jmcphers
Copy link
Collaborator

jmcphers commented Aug 8, 2024

Also covered (partly?) by #2861

@softwarenerd softwarenerd mentioned this issue Aug 8, 2024
Merged
@softwarenerd
Copy link
Contributor Author

Addressed in #4295.

@softwarenerd
Copy link
Contributor Author

Also covered (partly?) by #2861

Thanks, @jmcphers. I've assigned #2861 to myself and moved it into the PR Ready state.

wesm pushed a commit that referenced this issue Aug 8, 2024
@softwarenerd
Refine how the ColumnNullPercent component is painted (#4295)
d1012cc 
This PR addresses #2861 and
#4291 by refining how the
`ColumnNullPercent` component is painted.

Now, when the column null percent is 100% or 0%, the graph is painted at
100% red or 0% red:


![image](https://github.com/user-attachments/assets/f469e5f7-4698-4efd-b3d4-74859afe81ec)

When the column null percent is less than 5%, the graph is painted at 5%
so that it registers properly:


![image](https://github.com/user-attachments/assets/20ffe522-3be9-432f-976e-14c5375b4830)

Similarly, when the column null percent is greater than 95%, the graph
is painted at 95% so that it registers properly:


![image](https://github.com/user-attachments/assets/b85ba64f-ee32-4aca-8af2-d93940c18305)

Finally, as can be seen in the screen shots above, the graph is now
clipped to prevent it from bleeding outside its bounds (which was
happening, here's how that used to look):


![image](https://github.com/user-attachments/assets/e1a6a3a0-acf2-413f-b5bd-7275f182f836)
@softwarenerd softwarenerd mentioned this issue Aug 8, 2024
Closed
@softwarenerd
Copy link
Contributor Author

#2861 has been closed as a duplicate.

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.08.0-24
OS Version          : OSX

Test scenario(s)

Used polars data frame from qa-example-content with column b equal to null. Looks good.

Link(s) to TestRail test cases run or created:
N/A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@softwarenerd softwarenerd

Labels
area: data explorer Issues related to Data Explorer category. area: ui Issues related to UI category.
Projects
None yet
Milestone
2024.09.0 Pre-Release
Development

No branches or pull requests
3 participants
@jmcphers @softwarenerd @testlabauto