R environment pane: named list expansion #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
reviewed
Mar 31, 2023
extensions/positron-r/amalthea/crates/ark/src/environment/variable.rs
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/environment/variable.rs
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/environment/r_environment.rs
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/environment/r_environment.rs
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/environment/variable.rs
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/environment/variable.rs
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/environment/variable.rs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| .ps.environment_extract <- function(env, path) { | ||
| object <- env |
There was a problem hiding this comment.
Nit: the usages above seem to imply this function returns an R list, but it seems like it's returning an environment?
There was a problem hiding this comment.
It actually returns whatever the path means, i.e. if we have c("foo", "bar", "[[1]]") then it will return <env>$foo$bar[[1]] but this function is a temporary thing anyway, this will need eventually to be more careful if e.g. <env>$foo is an environment and bar is an active binding or a promise in this environment etc ...
I think the function will eventually be replaced by some rust logic.
extensions/positron-r/amalthea/crates/ark/src/lsp/modules/public/environment.R
Outdated
Show resolved
Hide resolved
extensions/positron-r/amalthea/crates/ark/src/lsp/modules/public/environment.R
Outdated
Show resolved
Hide resolved
|
Now handling things like Date, POSIXct, and POSIXlt via
|
|
Merging this now, but carrying on ... |
kevinushey
reviewed
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very minimal and limited so far, i.e. only lists can be expanded (this includes data.frames), but at least this wires things for Inspect and Details messages.