Run all smoke tests on merge to main #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonvanausdeln
previously approved these changes
Jul 24, 2024
testlabauto
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the testing flow of smoke tests run with PRs and merges to main. Previously, the same github action was run on pull request and on merge to main. That action would run some unit, some integration, and some smoke tests (tagged with #pr). Now, instead of running the same action on PR and on merge, the on-merge action has been updated to run all smoke tests on merge to main (not just the ones tagged with #pr).
The smoke tests are broken up in this fashion because they are time consuming. The idea is to keep the PR set of tests under 7 minutes. If the merge-to-main tests fail, the PR author will be notified via email by github as long as they have their notification settings properly configured (https://github.com/settings/notifications):
QA Notes
All smoke tests should pass.