Do not allow sending events responses while handling RPC messages #4617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue while running viewing a small polars data frame. In this case, the background tasks that return the null cournts would be processed faster than the actual RPC message, leading to an issue where the
send_event
is sent beforesend_result
, but with the message id fromsend_result
, which cause positron to interpret the event and the return value of the RPC message.This PR makes sure
send_event
waits for for the RPC message to be handled before sending the event results.