Fix/3472 keyboard shortcuts display incorrectly #4621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3472.
Prior to this PR, each character in a custom context menu shortcut was being displayed with a
letter-spacing
of.2rem
. This resulted in incorrect display of custom context menu shortcuts on Windows and Linux:Now, on macOS, custom context menu shortcuts are adjusted such that
⇧
,⌥
, and⌘
are displayed with a trailing space by this code:Here's a screenshot of this in action:
With this change, our custom context menu shortcuts now match system context menu shortcuts on macOS:
And on Windows and Linux:
QA Notes
None.