Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/3472 keyboard shortcuts display incorrectly #4621

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Sep 10, 2024

This PR addresses #3472.

Prior to this PR, each character in a custom context menu shortcut was being displayed with a letter-spacing of .2rem. This resulted in incorrect display of custom context menu shortcuts on Windows and Linux:

image

Now, on macOS, custom context menu shortcuts are adjusted such that , , and are displayed with a trailing space by this code:

label = label.replace('⇧', '⇧ ');
label = label.replace('⌥', '⌥ ');
label = label.replace('⌘', '⌘ ');

Here's a screenshot of this in action:

image

With this change, our custom context menu shortcuts now match system context menu shortcuts on macOS:

image

And on Windows and Linux:

image

QA Notes

None.

@softwarenerd softwarenerd merged commit 40ffb71 into main Sep 10, 2024
2 checks passed
@softwarenerd softwarenerd deleted the fix/3472-keyboard-shortcuts-display-incorrectly branch September 10, 2024 05:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants