If it's OK to do so, drive focus into the newly-created CodeEditorWidget #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Sep 16, 2024
dfalbel
approved these changes
Sep 16, 2024
softwarenerd
deleted the
console-ui/scroll-to-bottom-after-providing-input
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #4136.
Prior to this PR, after a user is prompted for input, the Console does not scroll to or focus the next ConsoleInput:
Screen.Recording.2024-09-13.at.6.48.53.PM.mov
With this PR, after a user is prompted for input, the Console scrolls to and focuses the next ConsoleInput:
Screen.Recording.2024-09-13.at.6.50.16.PM.mov
QA Notes
To test this, open an R console and press Enter until it begins to scroll. Then execute:
And provide input. Notice that when the next ConsoleInput is rendered, it will be scrolled into view and focused.