UI/theme updates #4762
Merged
UI/theme updates #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarenerd
force-pushed
the
ui/theme-updates
branch
from
b529b4a
to
af8984d
Compare
…lors for comparison purposes
softwarenerd
force-pushed
the
ui/theme-updates
branch
from
2be0749
to
0b15a7f
Compare
jmcphers
previously approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #3473 by doing two things:
dark_modern.jsonandlight_modern.jsonthemes have been reverted so they match their VS Code counterparts, which have been updated over time with colors being added, subtracted, and modified.Added two new themes called
positron_dark.jsonandpositron_light.jsonwhich includedark_modern.jsonandlight_modern.jsonand override colors for Positron.In addition, we've switched from using
terminal.backgroundto usingpanel.backgroundfor all our panel / editor backgrounds.panel.backgroundis now defined inpositron_dark.jsonandpositron_light.json.QA Notes
None