Isolate VSCode extension lint and formatting checks #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
force-pushed
the
dotnomad/iso-lint-vscode
branch
5 times, most recently
from
03d2168
to
b931f8b
Compare
dotNomad
force-pushed
the
dotnomad/iso-lint-vscode
branch
from
b931f8b
to
1e6d9a0
Compare
dotNomad
changed the title
dotNomad
commented
Mar 20, 2024
Comment on lines
+12
to
+15
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
| cache-dependency-path: '**/package-lock.json' |
There was a problem hiding this comment.
I was able to use Node 20 right away here to help with #908.
I also setup NPM dependency caching so this workflow is extremely lightweight.
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
mmarchetti
approved these changes
Mar 21, 2024
tdstein
approved these changes
Mar 21, 2024
Base automatically changed from
dotnomad/vscode-format
to
prettier-introduction-integration-branch
March 21, 2024 18:10
sagerb
merged commit 90eccff
into
prettier-introduction-integration-branch
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we were linting in docker, and in every OS in our native workflow matrixes. This PR splits that up so we only running linting and formatting checks once.
This was done partially to address Prettier failing on Windows (most likely due to actions/checkout#135).
It was also done to reduce our CI's runtime slightly, and provide an easy avenue for adding to our linting and formatting checks as the work in #1030 continues.
Intent
Type of Change
Approach
To do this I needed to split out the dependency installation in the
extensions/vscode/justfile. It used to be done injust vscode configurenowjust vscode depsinstalls them (installis already being used so I couldn't match it with the web justfile).just vscode configurecallsjust depsso we don't need to chain commands.