Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta1 Release Update #1811

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Beta1 Release Update #1811

merged 3 commits into from
Jun 7, 2024

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Jun 7, 2024

This PR makes changes for the v1.0.beta1 tag including:

  • Updates to the CHANGELOG
  • Updates to the install documentation
  • The install script

@dotNomad
Copy link
Collaborator Author

dotNomad commented Jun 7, 2024

Verified that the licenses didn't change.

./install-publisher.bash 1.0.alpha6
./install-publisher.bash 1.0.beta1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good that we added the beta bit here, but for posterity, we can leave this to be an older version than was released since it's supposed to show "you can downgrade too!" and that will encourage that.

Also, hopefully prevent cargo culting of folks always specifying the version there.

... for the like 4 people who will ever use this once we get on the marketplace

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. I was thinking alpha6 was old enough that this warranted an upgrade so it didn't look too out of date. I can absolutely get rid of the change if you think it'd be more valuable to have the older version there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, let's leave the bump to beta now that we are there. Just wanted to make sure anyone doing this next time didn't also feel compelled

@dotNomad dotNomad merged commit 70db666 into main Jun 7, 2024
12 checks passed
@dotNomad dotNomad deleted the dotnomad/beta-1 branch June 7, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants