fix: Escape HTML tags in tag docstrings so they don't break our docs #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the name and title of the
htmltools.tagsfunctions in https://shiny.posit.co/py/api/core/ui.tags.html but they're unprotected HTML, resulting in a broken table.Fixes posit-dev/py-shiny#1337
This was reported on Discord and then by Randy. Thanks @gregswinehart for the push to find the fix.
I haven't re-generated docs. I'm hoping @schloerke might have the time to carry this fix through to https://shiny.posit.co/py