Skip to content

Commit

Permalink
bug(ci): Split narwhals integration command into two commands (#1731)
Browse files Browse the repository at this point in the history
  • Loading branch information
schloerke authored Oct 10, 2024
1 parent 3f120ea commit bd0ea5c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/pytest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,9 @@ jobs:
- name: Setup py-shiny
id: install
uses: ./.github/py-shiny/setup
- name: Run test
- name: Run test commands
env:
UV_SYSTEM_PYTHON: 1
run: |
make test-narwhals-integration
make narwhals-install-shiny
make narwhals-test-integration
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,9 @@ upgrade-html-deps: FORCE ## Upgrade Shiny's HTMLDependencies
fi
@scripts/htmlDependencies.R

test-narwhals-integration: FORCE
narwhals-install-shiny: FORCE
@echo "-------- Install py-shiny ----------"
$(MAKE) ci-install-deps
narwhals-test-integration: FORCE
@echo "-------- Running py-shiny tests ----------"
$(MAKE) test playwright TEST_FILE="tests/playwright/shiny/components/data_frame" PYTEST_BROWSERS="--browser chromium"

0 comments on commit bd0ea5c

Please sign in to comment.