Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data frame): Add .update_cell() and .update_data() #1719

Merged
merged 27 commits into from
Oct 9, 2024
Merged

feat(data frame): Add .update_cell() and .update_data() #1719

merged 27 commits into from
Oct 9, 2024

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 4, 2024 •
edited
Loading

Fixes #1449

Update Cell Value

  • Implement basic working function
  • Send cell value as is.
    • Process it by the session
  • Assertion on the row and column index values
  • Test assertions
  • Write test app
  • Test app
  • Changelog entry

Update data

  • Implement basic working function
  • Reset data frame's .data() value
  • Reset cell patches
  • Process all cell values
    • Process it by the session
  • Cleanup on the sort, filter, typeHint values
  • Write test app
  • Test app
    • Fix .expect_nrow() on controller.OutputDataFrame
  • Changelog entry

@schloerke schloerke added the data frame Related to @render.data_frame label Oct 4, 2024
@schloerke
Add support for column to be a string. Add assertions
65fe19f
@schloerke
Rename params to row and col
a228b78
@schloerke
Remove unnecessary session context
f0d9c12
@schloerke
Update app to work with new update code
da3aef8
@schloerke
Merge branch 'main' into df_update_cell
03167d1 
* main:
  chore(docs): Update dev install instructions (#1721)
  chore(pyright): Unlock pyright version with minimum at `1.1.383` (#1722)
@schloerke
Working version of .update_data(self, data)
2ba95de
@schloerke
Allow for new columns and type hints! (Needs testing)
10dec9c
@schloerke
todos
5660a76
@schloerke
Require self session when serializing / registering any components
d67c4c6
@schloerke
Clean up some python code
ad5fcf5
@schloerke
Fix app
19a2a61
@schloerke
Do not call style update method until the cell patches or data updates
e8e1a38
@schloerke
Remove print statements
3173c4d
@schloerke
Clone data before processing it to avoid in-place updates; Raised nar…
7b44816 
…whals-dev/narwhals#1154
@schloerke
Expose .data_patched()
01b5e36
@schloerke
Talk about the different data methods available to the shiny data frame
bf2f6c2
@schloerke
Make reactives variable names clearer
8adf597
@schloerke
Add tests to .update_cell_value() and .update_data()
75648f7
@schloerke schloerke changed the title feat(data frame): Add .update_cell() to data frame renderer feat(data frame): Add .update_cell() and .update_data() Oct 8, 2024
@schloerke schloerke requested a review from jcheng5 October 8, 2024 20:45
@schloerke schloerke marked this pull request as ready for review October 9, 2024 18:14
jcheng5
jcheng5 approved these changes Oct 9, 2024
View reviewed changes
shiny/render/_data_frame.py Outdated Show resolved Hide resolved
shiny/render/_data_frame.py Show resolved Hide resolved
shiny/render/_data_frame.py Outdated Show resolved Hide resolved
@schloerke schloerke merged commit 94aa528 into main Oct 9, 2024
40 checks passed
@schloerke schloerke deleted the df_update_cell branch October 9, 2024 21:58
This was referenced Oct 10, 2024
Closed
Open
schloerke added a commit that referenced this pull request Oct 10, 2024
@schloerke
Merge branch 'main' into docs-machow-description-list
161fcc7 
* main:
  feat(data frame): Add `.update_cell()` and `.update_data()` (#1719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

Assignees
No one assigned
Labels
data frame Related to @render.data_frame
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(data_frame): Add .update_data(data, *, reset) and .update_cell_value(value, *, row, col)
2 participants
@schloerke @jcheng5