Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filling layout #115

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add support for filling layout #115

merged 4 commits into from
Nov 10, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Nov 7, 2023

TODO

  • Make sure this works with Quarto
  • Do a test run through more widgets
  • Make sure specified height/width works sensibly
  • Finish updating examples to leverage fill
  • Remove the examples/fill/app.py?
  • Clean-up/simplify resize logic
  • Make sure we aren't mutating objects
  • Update example requirements
  • Make it possible to opt out of fill in the output_widget

js/src/output.ts Outdated Show resolved Hide resolved
@jcheng5
Copy link
Collaborator

jcheng5 commented Nov 9, 2023

My only concern for the record--should not hold up merging--is that this is assuming that the vast majority of widgets are going to want to fill. This might turn out to be true, but if not, then we'll have to be ready to respond.

@jcheng5 jcheng5 marked this pull request as ready for review November 9, 2023 22:40
Copy link
Collaborator

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than async/await

@cpsievert cpsievert merged commit a888ca2 into main Nov 10, 2023
5 checks passed
@cpsievert cpsievert deleted the fill branch November 10, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants