Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webR: Continue initialisation even if package mounting fails #167

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

georgestagg
Copy link
Collaborator

A first step in handling quarto-ext/shinylive#59.

This wraps the mounting of bundled Wasm R packages in a try(), so that if something goes wrong (e.g. the .data file is not there for whatever reason) we recover and continue without the package, and try to start the Shiny app anyway.

This will likely be OK, since the missing package will instead be picked up from the public https://repo.r-wasm.org repo when (and if) it is actually used, which was always intended to be the fallback mode for when a required package is not included in the bundled Wasm assets.

Closes #163.

@georgestagg georgestagg requested a review from wch July 31, 2024 14:10
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wch wch merged commit 633f0c0 into posit-dev:main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webR: Handle missing .data files gracefully
2 participants