fix \FA already defined #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't work if one wants to use font awesome. |
FloThinksPi
added a commit
to FloThinksPi-Forks/Awesome-CV
that referenced
this pull request
Nov 11, 2018
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object. As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>. Fixes posquit0#221 by unsetting /FA before redefining it. In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change. Tested with MikTex on Windows.
jumper047
pushed a commit
to jumper047/Awesome-CV
that referenced
this pull request
Oct 29, 2021
Fixes Compilation Error when commenting out the \newfont: xdvipdfmx:fatal: pdf_ref_obj(): passed invalid object. As well als the Compilation Error: LaTeX3 Error: Command '\FA' already defined!For immediate help type H <return>. Fixes posquit0#221 by unsetting /FA before redefining it. In Contrary to other Pull Reqests posquit0#233 posquit0#235 and posquit0#236 i found, fontawsome works with this change. Tested with MikTex on Windows.
|
Thank you - I think many of us have made this or similar fixes over the years as posquit0's had other priorities. I have push access now to help maintain Awesome-CV; so I went with my old PR for this (#235/#344) for no reason other than my own familiarity, that I know it's been working for me. Please do ping me/open another PR if something's still not right or I missed something though! Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed \newfontfamily\FA{FontAwesome}
#221