Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality-of-life improvements #315

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

rhagenson
Copy link

Hello Byungjin Park (@posquit0), I am a huge fan of your awesome CV template and have been using it for a few years. During my use I have made some quality of life improvements that I wanted to contribute back upstream. The following changes have been made (in order of decreasing niceness of quality-of-life improvement):

  • Make it so socials are formatted in the same order as in the source file (i.e., allows deciding the order by rearranging lines in the source file)
  • Use the \needspace{...} command from the needspace package to prevent a page break after a section or subsection header so section content always starts on the same page as its header
  • Reorder \cventry{...}{...}... so that entries are: top-left, top-right, bottom-left, bottom-right, additional details (I always got this order wrong so now I use it as \cventry{...}{...}<newline>{...}{...}<newline>{...} so content in source matched where it will print in the final document)
  • The spacing of \cvhonor{...} has been updated to accommodate longer left and right entries (change made to use a date range on the left and non-domestic address on the right)

I anticipate you will want me to squash these commits before merging as my issue numbers do not correspond to your issue numbers so merging as is would create fake "this issue was referenced in commit" messages in the issue tracker, hence opening as a draft PR. If you want the changes upstream I will go through squashing, but do not want to delete the history prior to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants