Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for photo ID #55

Merged
merged 20 commits into from
Dec 2, 2016
Merged

Support for photo ID #55

merged 20 commits into from
Dec 2, 2016

Conversation

nitrogl
Copy link
Contributor

@nitrogl nitrogl commented Jul 4, 2016

Hi,

I've just added some support for photo ID following the way you use to write your latex code.
I transparently included in the \makeheader, hopefully in the right way.

The user is only supposed to (optionally) use the command \photoid.

% Usage: \photoid[circle|rectangle]{}
\newcommand{\photoid}[2][circle]{\def@phidedge{#1}\def@phid{#2}}

Hoping this may help.
Cheers,
Roberto

@xgenvn
Copy link

xgenvn commented Jul 9, 2016

+1

@nitrogl
Copy link
Contributor Author

nitrogl commented Jul 26, 2016

Additionally, I've added support for a gradient effect in the highlight section

@Cruel
Copy link

Cruel commented Sep 28, 2016

Works great. I didn't care much for the red photo border and I removed it, but other than that I'm definitely going to use this. 👍

@nitrogl
Copy link
Contributor Author

nitrogl commented Sep 28, 2016

Thanks Cruel for your feedback!
I've added support for "noedge" with examples in tex files; the edge colour, if present, is the same as the theme colour, not necessarily red.

@Masshat
Copy link

Masshat commented Sep 28, 2016

Hi Guys I guess that the owner of this repository is not checking this pull request any more, I think it is better if you continue the dev in your forked repo!

@posquit0
Copy link
Owner

I'll check this PR and merge to origin in a few days. Sorry to late response :(

@nitrogl
Copy link
Contributor Author

nitrogl commented Dec 1, 2016

Sure, thanks. I tried to follow the style you used to use as much as I could; please feel free to commit changes as well ;)

@posquit0 posquit0 merged commit 41d7a71 into posquit0:master Dec 2, 2016
@posquit0
Copy link
Owner

posquit0 commented Dec 2, 2016

Merged.
Thanks to your great implementation for profile photo.
I decided to rename 'photoid' to 'photo', to modify an effect of 'edge' mode and to remove gradient section color.
I added optional options('left|right') for 'photo' command to set the position of photo. In addition, \makecvheader command has a new options to align as well. (L: left, R: right, C: center)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants