Removes message cloning operation required for query router #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Jan 19, 2023
| @@ -93,7 +93,7 @@ | |||
| threads = Array.new(slow_query_count) do | |||
| Thread.new do | |||
| conn = PG.connect(processes.pgcat.connection_string("sharded_db", "sharding_user")) | |||
| conn.async_exec("SELECT pg_sleep(1)") | |||
| conn.async_exec("BEGIN") | |||
There was a problem hiding this comment.
It's faster than sleeping, that's for sure.
jmeagher
pushed a commit
to jmeagher/pgcat
that referenced
this pull request
Feb 17, 2023
Contains chore(deps): bump tokio from 1.24.1 to 1.24.2 (postgresml#286) Log error messages for network failures (postgresml#289) Removes message cloning operation required for query router (postgresml#285) Add more metrics to prometheus endpoint (postgresml#263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client currently needs to clone every message to determine if it is an admin command. This PR removes the need to clone and instead allows passing by reference.
Introduces the BytesMutReader trait to Cursor which helps to read null terminated chunks of strings.