Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker image runs erroring due to glibc incompatability #572

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

hi019
Copy link
Contributor

@hi019 hi019 commented Aug 30, 2023

The base Docker image used for building, rust:1, is running a different version of glibc than that of the image used for executing pgcat, debian:bullseye. And apparently Rust requires the that the glibc version used for building be compatible with the one used to execute the binary (rust-lang/rust#57497).

This PR fixes that and also upgrades the Debian version.

@hi019 hi019 changed the title Fix Docker image builds breaking due to glibc incompatability Fix Docker image runs erroring due to glibc incompatability Aug 30, 2023
@levkk
Copy link
Contributor

levkk commented Aug 30, 2023

Last time I used a recent Debian, we had a terrible regression in network performance. I would look out for those as you deploy your Docker images to production, but this is much better than not being able to start it at all. Thank you!

@levkk levkk merged commit 7994a66 into postgresml:main Aug 30, 2023
@hi019
Copy link
Contributor Author

hi019 commented Aug 31, 2023

Thanks for the heads up, will keep this in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants