Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang warns about unused variable in rum_ts_utils.c #3

Closed
jmscott opened this issue Aug 1, 2016 · 5 comments
Closed

clang warns about unused variable in rum_ts_utils.c #3

jmscott opened this issue Aug 1, 2016 · 5 comments

Comments

@jmscott
Copy link

jmscott commented Aug 1, 2016

clang warns about the unused variable 'extra_data' at line 722 in rum_ts_utils.c. adding a void cast of extra_data will safely silence the warning.

(void)extra_data

or just remove the declaration of 'extra_data'.

@za-arthur
Copy link
Contributor

Thank you for the issue! It was fixed.

Repository was updated. A lot of changes were done. For example, operator <-> was renamed to <=>, index is built faster.

@jmscott
Copy link
Author

jmscott commented Aug 2, 2016

will test today ... on a 6 million page database.

thanks for the hard work-john

On Tue, Aug 2, 2016 at 7:50 AM, Arthur [email protected] wrote:

Thank you for the issue! It was fixed.

Repository was updated. A lot of changes were done. For example, operator
<-> was renamed to <=>, index is built faster.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKDu0VxGZ0j-SKecDtRBQMLBp6sJmks5qbz0ugaJpZM4JZvmR
.

@za-arthur
Copy link
Contributor

Excellent!
I close the issue.

@jmscott
Copy link
Author

jmscott commented Aug 2, 2016

do i only rebuild the rum indexes?

On Tue, Aug 2, 2016 at 8:06 AM, Arthur [email protected] wrote:

Closed #3 #3.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWsKNXQl28VstMfyPB_OrRwRg7x5xTfks5qb0DBgaJpZM4JZvmR
.

@za-arthur
Copy link
Contributor

For better testing you also need uninstall extension from your database with built indexes (because rum introduce new operators and operator classes now). After that quit psql (if you use it). Then:

  • build extension from sources
  • install extension to your database
  • build index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants