Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘state’ may be used uninitialized in this function [-Wmaybe-uninitialized] #6

Closed
digoal opened this issue Aug 20, 2016 · 1 comment

Comments

@digoal
Copy link

digoal commented Aug 20, 2016

Hi,
There are two warnings when i make install rum.

my env:
PostgreSQL 9.6beta4
gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
CentOS 7.2 x64

make USE_PGXS=1 clean
rm -f rum.so   librum.a  librum.pc
rm -f rumsort.o rum_ts_utils.o rumtsquery.o rumbtree.o rumbulk.o rumdatapage.o rumentrypage.o rumget.o ruminsert.o rumscan.o rumutil.o rumvacuum.o rumvalidate.o rum_timestamp.o 
rm -rf results/ regression.diffs regression.out tmp_check/ log/
digoal@iZ28tqoemgtZ-> make USE_PGXS=1 
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumsort.o rumsort.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rum_ts_utils.o rum_ts_utils.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumtsquery.o rumtsquery.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumbtree.o rumbtree.c
rumbtree.c: In function ‘rumInsertValue’:
rumbtree.c:587:23: warning: ‘state’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      GenericXLogFinish(state);
                       ^
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumbulk.o rumbulk.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumdatapage.o rumdatapage.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumentrypage.o rumentrypage.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumget.o rumget.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o ruminsert.o ruminsert.c
ruminsert.c: In function ‘createPostingTree’:
ruminsert.c:81:20: warning: ‘state’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   GenericXLogFinish(state);
                    ^
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumscan.o rumscan.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumutil.o rumutil.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumvacuum.o rumvacuum.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rumvalidate.o rumvalidate.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -I. -I./ -I/home/digoal/pgsql9.6/include/server -I/home/digoal/pgsql9.6/include/internal -D_GNU_SOURCE   -c -o rum_timestamp.o rum_timestamp.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -O2 -fpic -shared -o rum.so rumsort.o rum_ts_utils.o rumtsquery.o rumbtree.o rumbulk.o rumdatapage.o rumentrypage.o rumget.o ruminsert.o rumscan.o rumutil.o rumvacuum.o rumvalidate.o rum_timestamp.o  -L/home/digoal/pgsql9.6/lib -Wl,--as-needed -Wl,-rpath,'/home/digoal/pgsql9.6/lib',--enable-new-dtags  
za-arthur pushed a commit that referenced this issue Aug 20, 2016
@za-arthur
Copy link
Contributor

Thank you!
Hm, my newer gcc does not show this warnings. Anyway I did changes in code to make your compiler more quite. Check please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants