This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
[OBS-137] Handle 409 response of create service to again check for service #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mudit-postman
commented
Sep 14, 2023
mudit-postman
commented
- Create a new model to parse error response
- Handle the 409 conflict case. Check for error message and call get services again
- Try only one time after that bail out with error
- Other small fixes: Add to cache after create service flow, small model change
shreys7
changed the title
shreys7
approved these changes
Sep 14, 2023
mgritter
approved these changes
Sep 14, 2023
|
|
||
| if httpErr, ok := err.(rest.HTTPError); ok && httpErr.StatusCode == 403 { | ||
| error := fmt.Errorf("You cannot send traffic to the collection with ID %s. "+ | ||
| if httpErr.StatusCode == 409 && errorResponse.Message == "collection_already_mapped" { |
There was a problem hiding this comment.
Please add a comment explaining the use case which requires this (a race between multiple agents trying to create the mirrored service.)
|
Merging so we can build a new agent release this morning |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.