Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #246: Connection does not close cleanly #248

Closed
wants to merge 2 commits into from
Closed

Fix for issue #246: Connection does not close cleanly #248

wants to merge 2 commits into from

Conversation

cmoesel
Copy link
Contributor

@cmoesel cmoesel commented Oct 4, 2013

Without this modification, calls to connection.end will close the socket without notifying the RabbitMQ server. This results in a warning in the RabbitMQ logs stating that the connection was closed abruptly.

This fix follows the AMQP 0-9-1 specification by sending the connectionClose method to the server and waiting for a connectionCloseOk response before closing the connection.

@aw
Copy link

aw commented Dec 14, 2013

👍 ✨

…l methods are received after sending the 'close' message.
@cmoesel
Copy link
Contributor Author

cmoesel commented Jan 13, 2014

I just discovered an issue that caused some tests to fail and I fixed it. All tests (including the new test for this feature) are now PASSING. Please merge or provide feedback to me if you need something else.

@gjohnson
Copy link
Contributor

👍

@postwait
Copy link
Owner

merged a combo of this and #295

@postwait postwait closed this Mar 12, 2014
@cmoesel cmoesel deleted the 246_connection_end branch September 5, 2014 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants