-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono repo take three #168
Mono repo take three #168
Conversation
Built from https://github.com/apache/couchdb-fauxton Looks and feels a lot nicer now, although many of the sidebar options don't work (e.g. config).
Also update README to note Fauxton branding and PouchDB.defaults API.
Notable additions: * startTime in db.info() * multipart/related support for PUT * changes with feed=continuous actually does a continuous feed like it's supposed to
Also clean up the multiparty usage a bit. Still doesn't replicate larger modules, but we're getting there. May require a change in PouchDB core so we don't have to read all the doc's attachments into memory at once.
Three things left to do:
|
We also need to put The basic idea is that the top-level If I have time I'll work on this but it looks like a 1-2 full days effort at least (judging based on the time I put into the pouchdb monorepo). |
I made some nice progress on this and am almost done. Tests are all passing. I've updated readme's and package.json. Pouchdb-server was actually added to the file structure on my machine as a subpackage but for some reason it wasn't added to the repo. At this stage I think the only thing that needs to be done is add the release functionality. I'm hoping @nolanlawson can help me with that otherwise I will take a look next week. Once we have done that i would like to merge this and then move the issues and PR's from express. Also cc @yaronyg and @gr2m to let them know about this since they have both expressed interest in this before. |
README.md
Outdated
Please make your changes on a separate branch whose name reflects your changes, push them to your fork, and open a pull request! | ||
|
||
For commit message style guidelines, please refer to [PouchDB CONTRIBUTING.md](https://github.com/pouchdb/pouchdb/blob/master/CONTRIBUTING.md). | ||
See the CONTRIBUTING.md file for how to get involved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe link the CONTRIBUTING.md file?
[CONTRIBUTING.md](https://github.com/pouchdb/pouchdb-server/blob/master/CONTRIBUTING.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
OK, I have cleaned up the structure a little bit, implemented a release script, and tested it on Sinopia to make sure everything is working correctly. Release instructions are now in Once this is green, I will merge and release 2.3.0 for both packages so we can get this in fast. (Note that we don't need to release 3.0.0 because there are no breaking changes here.) |
Awesome. Thanks for taking it over the finish line.
|
No prob. Last bit is just getting the README cleaned up. I'll do that before publishing. |
Done. 2.3.0 are published for both |
great work @garrensmith @nolanlawson 🎉 |
Had a few publishing snafus, but 2.3.3 should be good now. Fourth time's the charm. 😅 |
Woohoo. Thanks Nolan
|
This is my third and final push on getting this mono-repo. I've imported express-server in with full git history.