Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a different video player #78

Open
saskakol opened this issue Oct 23, 2018 · 7 comments
Open

Consider using a different video player #78

saskakol opened this issue Oct 23, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@saskakol
Copy link
Contributor

saskakol commented Oct 23, 2018

Perhaps it would be worth considering using a video player other than YouTube's iframe API.
One that I found recently is called Plyr. (I haven't tried it myself though, so can't confirm if it's suitable.) The advantage would be more control over the look of the player, and if the player supports different video sources(Plyr apparently supports YT, Vimeo, and HTML5 video) the APIs to control the playback would be standardised (so no writing separate code to control YouTube video versus an HTML5 video link for example)

@poush
Copy link
Owner

poush commented Oct 25, 2018

Seems interesting. It will be great to see if this can also play those music videos which can't be played through embed links.

@saskakol
Copy link
Contributor Author

@poush Not sure If it’s able to, YouTube might just be restricting what domains the videos can be played from.

@poush
Copy link
Owner

poush commented Oct 25, 2018 via email

@poush poush added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 25, 2018
@iblacker
Copy link
Contributor

iblacker commented Nov 1, 2018

I have tried implementing Plyr on H2 and it didn't some the issue "Video Unavailable". It has to do with certain videos being embedded in a localhost as opposite to a web server.

@saskakol
Copy link
Contributor Author

saskakol commented Nov 1, 2018

@iblacker Do you think it would work with a locally hosted web server?

@iblacker
Copy link
Contributor

iblacker commented Nov 1, 2018

I don't think it would. I can look into it later, though. Those videos work if you open the video's page, but not when it is embedded.

@poush
Copy link
Owner

poush commented Nov 3, 2018

The only way I could think right now is to open the youtube page directly for such videos and zoom on video player.

@poush poush assigned poush and unassigned poush Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants