Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring feature selection #19

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Refactoring feature selection #19

merged 3 commits into from
Nov 18, 2020

Commits on Nov 13, 2020

  1. NMI optimisations and tweaks 

    - Store target and cross NMI inside MODData by default
- Loop unique over pairs rather than rows and columns
- Fix edgecase when providing both df_featurized and structures
- Use same random seed when computing NMI for all features
- For constant features, explicitly set diagonal to NaN to avoid
  overflow elsewhere
    @ml-evs
    ml-evs committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    932c41a View commit details
    Browse the repository at this point in the history

  2. Added method for splitting underlying MODData by index

    @ml-evs
    ml-evs committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ee30f7d View commit details
    Browse the repository at this point in the history

  3. Added pytest marker for slow tests 

    Tweaked setup.py
    @ml-evs
    ml-evs committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    6cfcca4 View commit details
    Browse the repository at this point in the history