Drop Python 3.8 and update other deps #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/deps-again
branch
from
4425f35
to
38e0dbd
Compare
ppdebreuck
approved these changes
Mar 27, 2024
|
removed 3.8 as a required test on GitHub |
ml-evs
commented
Mar 27, 2024
Comment on lines
+927
to
+929
| if max_support - support[i] > 0: | ||
| sampled_x, sampled_y, sampled_struct = resample( | ||
| self.df_featurized.iloc[idxs], |
There was a problem hiding this comment.
Just to highlight that this is the one code change I had to make to support new versions, the rest are linter updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200 and bumps various other deps (numpy etc.) that are blocking #199.