Fix draw thread unnecessarily marking GL context as current #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susko3
approved these changes
Mar 20, 2023
smoogipoo
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wglMakeCurrent()errors are spammed to log when using Veldrid / OpenGL #5688I'll preface this by saying this only affects Veldrid/OpenGL, so this doesn't need immediate attention at all and can be left for another release if preferred.
MakeCurrentcalls are supposed to happen internally within the renderer whenever it's expecting to execute GL commands. In Veldrid, all GL commands are executed in a separate thread, therefore callingMakeCurrenthere is unnecessary and will fail due to being acquired in the Veldrid thread.I've kept the
ClearCurrentcall though since I'm not entirely sure of a better place for it that exists onGLRenderer, and I'm slightly skeptical of doing it inFinishFrame.