HitResults with the same name show across two columns in beatmap rankings

[peppy]

Discussed in #29904

^{Originally posted by 424ever September 18, 2024}
When looking at the scores on this map in game, there are 2 columns labeled as "Slider End". I think these should be combined into a single column.

There is (currently) only one score which uses the left column, which was set on Lazer with the Classic mod.

---

This is awkward as hell to attempt to fix.

Relevant code:

osu/osu.Game.Rulesets.Osu/OsuRuleset.cs

Lines 296 to 298 in 998b5fd

	case HitResult.SliderTailHit:
	case HitResult.SmallTickHit:
	return "slider end";

osu/osu.Game/Overlays/BeatmapSet/Scores/ScoreTable.cs

Lines 104 to 130 in e887f93

	var allScoreStatistics = scores.SelectMany(s => s.GetStatisticsForDisplay().Select(stat => stat.Result)).ToHashSet();
	var ruleset = scores.First().Ruleset.CreateInstance();
	foreach (var result in EnumExtensions.GetValuesInOrder<HitResult>())
	{
	if (!allScoreStatistics.Contains(result))
	continue;
	// for the time being ignore bonus result types.
	// this is not being sent from the API and will be empty in all cases.
	if (result.IsBonus())
	continue;
	var displayName = ruleset.GetDisplayNameForHitResult(result);
	columns.Add(new TableColumn(displayName, Anchor.CentreLeft, new Dimension(minSize: 35, maxSize: 60)));
	statisticResultTypes.Add((result, displayName));
	}
	if (showPerformancePoints)
	columns.Add(new TableColumn(BeatmapsetsStrings.ShowScoreboardHeaderspp, Anchor.CentreLeft, new Dimension(GridSizeMode.Absolute, 30)));
	columns.Add(new TableColumn(BeatmapsetsStrings.ShowScoreboardHeadersTime, Anchor.CentreLeft, new Dimension(GridSizeMode.AutoSize)));
	columns.Add(new TableColumn(BeatmapsetsStrings.ShowScoreboardHeadersMods, Anchor.CentreLeft, new Dimension(GridSizeMode.AutoSize)));
	return columns.ToArray();

Could group by localisable string base string, but it makes things very fiddly (currently it's pre-checking stats across all scores to be displayed, so it kinda has to happen before that). Would want a second opinion before attempting this.

[bdach]

Not sure it helps, but for reference this is how judgement counter handles the exact same problem right now:

osu/osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCountController.cs

Lines 34 to 36 in cf9f8c7

	// Due to weirdness in judgements, some results have the same name and should be aggregated for display purposes.
	// There's only one case of this right now ("slider end").
	foreach (var group in ruleset.Value.CreateInstance().GetHitResults().GroupBy(r => r.displayName))

[peppy]

Not sure it helps, but for reference this is how judgement counter handles the exact same problem right now

Yeah I found this in passing, but still a bit of a pain to implement.