Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images on comparison chart #108

Merged
merged 2 commits into from
May 9, 2022
Merged

Fix images on comparison chart #108

merged 2 commits into from
May 9, 2022

Conversation

danm
Copy link
Contributor

@danm danm commented May 9, 2022

Hi, I guess you changed the location of some of your images, just a pr to fix them.
got here from https://medium.com/autodesk-tlv/lerna-has-gone-which-monorepo-is-right-for-a-node-js-backend-fc075cad51b0

updated location of images
@danm danm changed the title Update monorepo.md Fix images on comparison chart May 9, 2022
Updating comparison graph to show Lerna detects package changes.
Copy link
Contributor

@goldbergyoni goldbergyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danm Awesome fix, many thanks! 🛰

Let's see if Docusaurus tolerates these full paths

cc @relsteiner

@goldbergyoni goldbergyoni merged commit 102fcdf into practicajs:main May 9, 2022
@goldbergyoni
Copy link
Contributor

@all-contributors please add @danm for content

@allcontributors
Copy link
Contributor

@goldbergyoni

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 2306

@goldbergyoni
Copy link
Contributor

https://github.com/all-contributors please add @danm for content

@goldbergyoni
Copy link
Contributor

@all-contributors please add @danm for content

@allcontributors
Copy link
Contributor

@goldbergyoni

I've put up a pull request to add @danm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants