Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastify support #325

Merged
merged 15 commits into from
Apr 7, 2024
Merged

Fastify support #325

merged 15 commits into from
Apr 7, 2024

Conversation

goldbergyoni
Copy link
Contributor

TBD, WIP

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.63%. Comparing base (a204201) to head (b7dabea).

❗ Current head b7dabea differs from pull request most recent head 7be75fc. Consider uploading reports for the commit 7be75fc to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #325       +/-   ##
===========================================
- Coverage   90.92%   63.63%   -27.29%     
===========================================
  Files          16        2       -14     
  Lines         595       22      -573     
  Branches       43        3       -40     
===========================================
- Hits          541       14      -527     
+ Misses         53        7       -46     
  Partials        1        1
Flag Coverage Δ
app ?
generator 63.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rluvaton
rluvaton reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@rluvaton rluvaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, left some comments?

src/code-templates/libraries/error-handling/app-error.ts Show resolved Hide resolved
src/code-templates/libraries/error-handling/app-error.ts Show resolved Hide resolved
src/code-templates/libraries/error-handling/app-error.ts Show resolved Hide resolved
src/code-templates/libraries/error-handling/error-handler.ts Show resolved Hide resolved
src/code-templates/libraries/error-handling/fastify-error-middleware.ts Outdated Show resolved Hide resolved
src/code-templates/services/order-service/start.ts Show resolved Hide resolved
test/e2e-non-interactive-default-flags.slow.test.ts Outdated Show resolved Hide resolved
src/code-templates/libraries/error-handling/error-handler.ts Show resolved Hide resolved
src/code-templates/libraries/error-handling/error-handler.ts Show resolved Hide resolved
src/code-generator/test/generator.non-interactive-cli.test.ts Show resolved Hide resolved
@goldbergyoni goldbergyoni marked this pull request as ready for review April 3, 2024 13:58
@goldbergyoni goldbergyoni merged commit 4148ce9 into main Apr 7, 2024
7 of 8 checks passed
@goldbergyoni goldbergyoni deleted the feat/fastify-support branch April 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluvaton rluvaton rluvaton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldbergyoni @rluvaton