Fix URL in html_logo and html_favicon #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wheeee. I missed this. Thanks for the PR! This theme is Sphinx 4 only — which should simplify the patch. :) |
|
Great. Should I simply always use |
Since Sphinx 4, it's possible to use URL in html_logo and html_favicon options. It is not currently processed correctly and we end up with something like "_static/https://example.com/logo.png" as image path. Signed-off-by: Igor Ryzhov <[email protected]>
|
Yup yup! The Sphinx version check will always come out false. |
idryzhov
force-pushed
the
favicon-logo-url
branch
from
523edd9
to
93acd65
Compare
|
Done! Thanks for the review :) |
|
And thanks for the PR! I’ll cut a release with this sometime next week / coming weekend, based on what my calendar looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Sphinx 4, it's possible to use URL in html_logo and html_favicon
options. It is not currently processed correctly and we end up with
something like "_static/https://example.com/logo.png" as image path.
Signed-off-by: Igor Ryzhov [email protected]