Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed indentation rules to only apply when enter is pressed, to fix… #133

Merged
merged 5 commits into from
Dec 10, 2019

Conversation

onelivesleft
Copy link
Contributor

… copy+paste & move line being broken.

Fixes #127

@onelivesleft
Copy link
Contributor Author

Fixes #69

@onelivesleft
Copy link
Contributor Author

onelivesleft commented Dec 5, 2019

N.B. I looked at how the python extension does it, since it's a language people have been working with for a long time. They use OnEnterRules exclusively, and do not mess with auto-indent/dedent, which makes sense for a language with (A) semantic indentation and (B) no end-of-block delimiter.

Note this comment:

            // Note that we do not currently have an auto-dedent
            // solution for "elif", "else", "except", and "finally".
            // We had one but had to remove it (see issue #6886).

Issue#6886 is their version of the issues listed in this PR: microsoft/vscode-python#6886

@kosz78 kosz78 merged commit e3ed7a3 into pragmagic:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect indentation when pasting code
2 participants