Fix filesize display in file viewer #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badcf00d
changed the title
prasathmani
approved these changes
Dec 23, 2020
ner00
pushed a commit
to ner00/tinyfilemanager
that referenced
this pull request
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing page seems to always display the file size as bytes "B" even if it was supposed to show megabytes or kilobytes etc. It also seemed to have a problem with greater than 32 bit file sizes that would wrap around to show the file size as negative a billion bytes or something.
Mainly just copied the implementation from the folder view into the file info view.
Thanks,
Peter