fix When unsubscribe From SSE the _retryConnection method must stop #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikbaid3
reviewed
Aug 24, 2024
| @@ -23,6 +23,7 @@ class SSEClient { | |||
| required Map<String, String> header, | |||
| Map<String, dynamic>? body}) { | |||
| print('---RETRY CONNECTION---'); | |||
| if (!_streamController.isClosed) | |||
There was a problem hiding this comment.
@soufianebenyaala I have removed the static _steamController causing the limitation with the access to multiple stream listeners. But this is a good suggestion. I would suggest changing the reference from _streamController to streamController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.