New Streams #446
Merged
New Streams #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Multiple filters per stream * It's now possible to append data to compressed streams * Stream compression is reentrant (multiple calls to `compress!` will have stream deflated only once). * A few additional filters from PDF spec * ASCIIHex * ASCII85 * DCT filter is a stub as it's used only in JPEG images. It doesn't decode/encode JPEG images.
|
This should fix #434 as well as some other potential problems. |
|
This looks good to me. Anyone else want to review or have comments? |
| end | ||
| end | ||
|
|
||
| module ASCII85Decode |
There was a problem hiding this comment.
The Ascii85 gem is an indirect dependency via pdf-reader. Maybe this class should just delegate to that?
|
The AsciiHex and Ascii85 filter aren't used anywhere in the code base. I'm not keen on adding extra code that isn't used. I like this change in general and like that we can add the extra filter types if we ever need them. Maybe we should merge this work minus the unused filters? |
Threre probably should be a gem with all the filters that are not used in the core.
|
@yob Any other comments on this pull request? |
|
Nope. It looks good to me, but I'll leave it to Brad to merge if he's happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compress!will havestream deflated only once).
decode/encode JPEG images.