Connect Bugfixes/Additions + Minor Redesign #2
Conversation
* Menu:
* Fixed crashes on empty/malformed fields (`IP/Port/MasterServer`)
* Design:
* Added global Disconnect button and manual Connect button.
* Moved Server List up.
* Manual connection was moved to its own tree.
* Malformed fields are reset to default automatically (most of the time).
* General:
* Added Port options (settings & menu)
* Added `server/masterserver.json` config file.
* Attempted update of `server/Dockerfile` (for masterserver).
* Updated README(s) as needed.
|
Looks good. Not sure if I'm a fan of pointing the defaults away from my master server (at least for the client, I can understand it for the others). It is currently running, and I had planned to keep the server running for as long as I kept an interest in this project. I only bring it up because IMO the releases on GitHub should have some defaults set up for the end user so they can quickly discover existing servers. Unless you can get it to read from a config file to set the default master server, then the binaries themselves could get rid of that information, and I could just put it in a config file in the release zips. A side note: can you commit something to your branch again? I just added a workflow for building PRs but it won't let me retroactively build. I just want to make sure this PR will build on Actions. |
|
My bad, initially meant to keep the original master server. |
Menu:
IP/Port/MasterServer)General:
server/masterserver.jsonconfig file.server/Dockerfile(for masterserver).