Optimize game_namespace string concatenation and avoid copies
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again did some tests in Rise and RE2 in and out of VR, works perfectly fine, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, similarly to #505. I just found another function that's frequently called and that's doing more work than it should. Might not matter for performance at all, or might reduce CPU usage slightly due to the avoidance of copies and dynamic string allocations.
I am not sure if
thread_localis required, but I added it just to be safe. I also think it should be safe to change the return type tostd::string&as in the PR, but that should be double-checked as well.