DInputHook: Initialize g_dinput_hook before installing hook. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. It's been a while since I even looked at this particular piece of code, never would've even thought. |
Oh, its so nice when we can see the source code of what is misbehaving in Proton :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes frequent crashes during dinput hooking on Proton (on Windows too but there it is probably a rare occasion).
g_dinput_hook is used in the hook function. DInputHook::DInputHook() sets g_dinput_hook only after hook() finishes. The hook gets active in m_get_device_state_hook->create(), inside MH_EnableHook(). MH_EnableHook() suspends game threads, activates hook and resumes the threads. Once thread calling GetDeviceState() is resumed it may start calling the hook function. The patch fixes the crash which happens frequently under Steam Proton due to that. The crash happens much less often on Windows probably because Proton's ResumeThread() is slower to execute on the calling thread and faster to wake the thread being resumed compared to Windows.